Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minor typos in docs/development-environment.md #8233

Merged
merged 1 commit into from
Nov 23, 2017
Merged

fix: Minor typos in docs/development-environment.md #8233

merged 1 commit into from
Nov 23, 2017

Conversation

jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Nov 23, 2017 •
edited
Loading

Changes proposed in this Pull Request:

  • Fixes some minor typos in docs/development-environment.md

I was just digging in a bit and thought I'd fix these while I was reading it myself.

@jaswrks jaswrks requested a review from jeherve as a code owner November 23, 2017 08:55
@jaswrks jaswrks closed this Nov 23, 2017
@jaswrks jaswrks reopened this Nov 23, 2017
@oskosk
Copy link
Contributor

oskosk commented Nov 23, 2017 •
edited
Loading

Thank you! If this is ready for review, please label as such

@jaswrks
Copy link
Contributor Author

jaswrks commented Nov 23, 2017

@oskosk It is ready, yes. Thank you.
Sorry, I don't have access to Labels in this repo.

@oskosk oskosk added the [Status] Needs Review This PR is ready for review. label Nov 23, 2017
@oskosk
Copy link
Contributor

oskosk commented Nov 23, 2017

oh right. Sorry.

oskosk
oskosk approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! Docs and removed [Status] Needs Review This PR is ready for review. labels Nov 23, 2017
@oskosk oskosk merged commit 4941fe2 into Automattic:master Nov 23, 2017
@oskosk
Copy link
Contributor

oskosk commented Nov 23, 2017

It's merged now. Thank you again!

@oskosk oskosk added this to the 5.6 milestone Dec 8, 2017
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskosk oskosk oskosk approved these changes

@jeherve jeherve Awaiting requested review from jeherve

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.
3 participants
@jaswrks @oskosk @kraftbj